Re: [PATCH] libbpf: Fix readelf output parsing for Fedora
From: Alexei Starovoitov
Date: Sun Dec 15 2019 - 12:42:50 EST
On Fri, Dec 13, 2019 at 9:02 AM Andrii Nakryiko
> On Fri, Dec 13, 2019 at 2:11 AM Thadeu Lima de Souza Cascardo
> <cascardo@xxxxxxxxxxxxx> wrote:
> > Fedora binutils has been patched to show "other info" for a symbol at the
> > end of the line. This was done in order to support unmaintained scripts
> > that would break with the extra info. 
> >  https://src.fedoraproject.org/rpms/binutils/c/b8265c46f7ddae23a792ee8306fbaaeacba83bf8
> > This in turn has been done to fix the build of ruby, because of checksec.
> >  Thanks Michael Ellerman for the pointer.
> >  https://bugzilla.redhat.com/show_bug.cgi?id=1479302
> > As libbpf Makefile is not unmaintained, we can simply deal with either
> > output format, by just removing the "other info" field, as it always comes
> > inside brackets.
> > Cc: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> > Fixes: 3464afdf11f9 (libbpf: Fix readelf output parsing on powerpc with recent binutils)
> > Reported-by: Justin Forbes <jmforbes@xxxxxxxxxxx>
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxx>
> > ---
> I was briefly playing with it and trying to make it use nm to dump
> symbols, instead of parsing more human-oriented output of readelf, but
> somehow nm doesn't output symbols with @@LIBBPF.* suffix at the end,
> so I just gave up. So I think this one is good.
> This should go through bpf-next tree.
> Acked-by: Andrii Nakryiko <andriin@xxxxxx>