Re: [PATCH] net: caif: replace BUG_ON with recovery code

[Geert Uytterhoeven]

Hi Aditya,

On Sun, Dec 15, 2019 at 6:51 PM Aditya Pakki <pakki001@xxxxxxx> wrote:
> In caif_xmit, there is a crash if the ptr dev is NULL. However, by
> returning the error to the callers, the error can be handled. The
> patch fixes this issue.
>
> Signed-off-by: Aditya Pakki <pakki001@xxxxxxx>

Thanks for your patch!

> --- a/drivers/net/caif/caif_serial.c
> +++ b/drivers/net/caif/caif_serial.c
> @@ -270,7 +270,9 @@ static int caif_xmit(struct sk_buff *skb, struct net_device *dev)
>  {
>         struct ser_device *ser;
>
> -       BUG_ON(dev == NULL);
> +       if (WARN_ON(!dev))

This will still crash the kernel with panic_on_warn.

> +               return -EINVAL;
> +
>         ser = netdev_priv(dev);
>
>         /* Send flow off once, on high water mark */

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds