Re: [PATCH] EDAC: remove set but not used variable 'ecc_loc'

From: yukuai (C)
Date: Sun Dec 15 2019 - 20:12:09 EST

On 2019/12/14 7:11, Luck, Tony wrote:
On Fri, Dec 13, 2019 at 08:10:36PM +0800, yu kuai wrote:
@@ -499,7 +498,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
syndrome = dw2;
pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
- ecc_loc = i5100_redmemb_ecc_locator(dw2);
if (i5100_validlog_recmemvalid(dw)) {

This deletes the only call to i5100_redmemb_ecc_locator(). Should
we delete the definition of the function too?
Thank you for your response!
Yes, I think we can do that.

Yu Kuai

Is it worth making cosmetic cleanups to a driver for 12 year old h/w?