Re: [PATCH v2] tty/serial: atmel: fix out of range clock divider handling

From: David Engraf
Date: Mon Dec 16 2019 - 03:34:14 EST


On 13.12.19 at 17:07, Greg KH wrote:
On Fri, Dec 13, 2019 at 03:03:01PM +0100, David Engraf wrote:
Use MCK_DIV8 when the clock divider is > 65535. Unfortunately the mode
register was already written thus the clock selection is ignored.

Fix by doing the baud rate calulation before setting the mode.

Fixes: 5bf5635ac170 ("tty/serial: atmel: add fractional baud rate support")
Signed-off-by: David Engraf <david.engraf@xxxxxxxxx>
---
drivers/tty/serial/atmel_serial.c | 43 ++++++++++++++++---------------
1 file changed, 22 insertions(+), 21 deletions(-)

What changed from v1?

Always put that below the --- line.

Oh sorry.

v3 please?

Sure.

Best regards
- David

thanks,

greg k-h