Re: [PATCH] net: l2tp: remove unneeded MODULE_VERSION() usage
From: Leon Romanovsky
Date: Mon Dec 16 2019 - 04:04:32 EST
On Thu, Dec 12, 2019 at 11:03:54AM -0800, David Miller wrote:
> From: "Enrico Weigelt, metux IT consult" <info@xxxxxxxxx>
> Date: Thu, 12 Dec 2019 14:36:13 +0100
>
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
> >
> > Signed-off-by: Enrico Weigelt, metux IT consult <info@xxxxxxxxx>
>
> Is there a plan to remove MODULE_VERSION across the entire kernel tree?
>
> Where is that documented?
>
> Otherwise what gave you the reason to make this change in the first place?
Dave, see this conversation which I had two years ago with positive
responses from many respectable developers.
https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2017-June/004421.html
Greg's response:
https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2017-June/004441.html
Linus's response:
https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2017-June/004426.html
Thanks
>
> No context, no high level explanation of what's going on, so it's hard
> to review and decide whether to accept your change sorry.
>
> At the least, you will have to write a more complete commit log message.