Re: [PATCH] media: saa7146: Avoid using BUG_ON as an assertion
From: Markus Elfring
Date: Mon Dec 16 2019 - 05:22:47 EST
â
> +++ b/drivers/media/common/saa7146/saa7146_video.c
@@ -345,7 +345,8 @@ static int video_begin(struct saa7146_fh *fh)
â
- BUG_ON(NULL == fmt);
+ if (NULL == fmt)
â
Would you like to express a null pointer check in a succinct way?
+ if (!fmt)
Will the tag âFixesâ become helpful for the change description?
Regards,
Markus