Re: [PATCH v3 1/2] dt-bindings: PCI: qcom: Add support for SDM845 PCIe

[Andrew Murray]

On Wed, Nov 06, 2019 at 04:16:41PM -0800, Bjorn Andersson wrote:
> Add compatible and necessary clocks and resets definitions for the
> SDM845 PCIe controller.
> 
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---

Reviewed-by: Andrew Murray <andrew.murray@xxxxxxx>

> 
> Changes since v1:
> - Picked up Rob and Vinod's R-b
> 
>  .../devicetree/bindings/pci/qcom,pcie.txt     | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> index ada80b01bf0c..981b4de12807 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> @@ -11,6 +11,7 @@
>  			- "qcom,pcie-ipq4019" for ipq4019
>  			- "qcom,pcie-ipq8074" for ipq8074
>  			- "qcom,pcie-qcs404" for qcs404
> +			- "qcom,pcie-sdm845" for sdm845
>  
>  - reg:
>  	Usage: required
> @@ -126,6 +127,18 @@
>  			- "master_bus"	AXI Master clock
>  			- "slave_bus"	AXI Slave clock
>  
> +-clock-names:
> +	Usage: required for sdm845
> +	Value type: <stringlist>
> +	Definition: Should contain the following entries
> +			- "aux"		Auxiliary clock
> +			- "cfg"		Configuration clock
> +			- "bus_master"	Master AXI clock
> +			- "bus_slave"	Slave AXI clock
> +			- "slave_q2a"	Slave Q2A clock
> +			- "tbu"		PCIe TBU clock
> +			- "pipe"	PIPE clock
> +
>  - resets:
>  	Usage: required
>  	Value type: <prop-encoded-array>
> @@ -188,6 +201,12 @@
>  			- "pwr"			PWR reset
>  			- "ahb"			AHB reset
>  
> +- reset-names:
> +	Usage: required for sdm845
> +	Value type: <stringlist>
> +	Definition: Should contain the following entries
> +			- "pci"			PCIe core reset
> +
>  - power-domains:
>  	Usage: required for apq8084 and msm8996/apq8096
>  	Value type: <prop-encoded-array>
> -- 
> 2.23.0
>