Re: [PATCH 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support

[Miquel Raynal]

Hi Sam,

Sam Ravnborg <sam@xxxxxxxxxxxx> wrote on Sat, 14 Dec 2019 11:09:11
+0100:

> Hi Miquel.
> 
> On Fri, Dec 13, 2019 at 07:23:25PM +0100, Miquel Raynal wrote:
> > Add support for the Satoz SAT050AT40H12R2 RGB panel.  
> 
> Google failed to find this display - do you have any pointers to
> datasheet?
> 
> This turned up: SAT050AT40H12B2
> But I failed to find any data sheet.

I could not find the datasheet myself on the Internet, I found other
datasheets of other panels from the same vendor though.

I confirm I am talking about the R2 package (not B2 your find).

> 
> I wonder if there is any typical, min, max timings - so we could use
> display_timing rather than display_mode.

Yes there are min/typ/max timings in the datasheet, I didn't know about
display_mode (copied/pasted another random timing structure and adapted
it). I will try to adapt.

> 
> Before the compatible is documented the patch will not be applied.
> So you need to submit a binding document too,
> which must be in meta-schema syntax (.yaml).

Any reason to create one (almost empty) file by compatible? As
comparison, simple I2C/SPI devices with no singularities are
listed there:
Documentation/devicetree/bindings/trivial-devices.yaml

I'll create a bindings file for this panel though.

Thanks,
MiquÃl