Re: [PATCH] drm/panel: simple: Support reset GPIOs

From: Miquel Raynal
Date: Mon Dec 16 2019 - 05:53:38 EST


Hi Sam,

Sam Ravnborg <sam@xxxxxxxxxxxx> wrote on Sat, 14 Dec 2019 11:23:54
+0100:

> Hi Miquel.
>
> On Fri, Dec 13, 2019 at 07:13:25PM +0100, Miquel Raynal wrote:
> > The panel common bindings provide a gpios-reset property which is
> > active low by default. Let's support it in the simple driver.
> >
> > De-asserting the reset pin implies a physical high, which in turns is
> > a logic low.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
>
> Code looks fine - but I fail to see why simple panels would require a
> reset pin.
>
> Do you have any simple panels that requires this, or did you add it
> because you saw it in the panel-common.yaml file?

My hardware is:

LVDS IP <----------> LVDS to RGB bridge <------------> Panel

While there is a simple "RGB to LVDS" bridge driver, there is none
doing the work the other way around. In my case, the bridge has a reset
pin.

As until now there is no way to represent the "LVDS to RGB" bridge and
because the bindings already document such reset pin, I decided to add
support for it in the simple panel driver.

Thanks,
MiquÃl