Re: [PATCH v2 4/4] eeprom: at24: remove the write-protect pin support

[Bartosz Golaszewski]

pon., 16 gru 2019 o 09:13 Linus Walleij <linus.walleij@xxxxxxxxxx> napisaÅ(a):
>
> On Tue, Dec 10, 2019 at 4:42 PM Khouloud Touil <ktouil@xxxxxxxxxxxx> wrote:
>
> > NVMEM framework is an interface for the at24 EEPROMs as well as for
> > other drivers, instead of passing the wp-gpios over the different
> > drivers each time, it would be better to pass it over the NVMEM
> > subsystem once and for all.
> >
> > Removing the support for the write-protect pin after adding it to the
> > NVMEM subsystem.
> >
> > Signed-off-by: Khouloud Touil <ktouil@xxxxxxxxxxxx>
>
> I wonder if this needs to be in the same patch that adds it to
> the NVMEM subsystem, so as to avoid both code paths being
> taken between the two patches (bisectability..)
>
> However that is not the biggest thing in the universe and I'm
> no bisectability-perfectionist, so:
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> Yours,
> Linus Walleij

AFAIK Khouloud tested it and it's bisectable thanks to using the
optional gpiod_get() variant.

Best regards,
Bartosz Golaszewski