Re: [PATCH] bpf: Replace BUG_ON when fp_old is NULL

From: Daniel Borkmann
Date: Mon Dec 16 2019 - 06:18:01 EST


On 12/15/19 11:08 PM, Yonghong Song wrote:
On 12/15/19 7:44 AM, Aditya Pakki wrote:
If fp_old is NULL in bpf_prog_realloc, the program does an assertion
and crashes. However, we can continue execution by returning NULL to
the upper callers. The patch fixes this issue.

Could you share how to reproduce the assertion and crash? I would
like to understand the problem first before making changes in the code.
Thanks!

Fully agree, Aditya, please elaborate if you have seen a crash!