Re: [PATCH V2] EDAC: remove set but not used variable 'ecc_loc'

[Mauro Carvalho Chehab]

Em Mon, 16 Dec 2019 19:01:21 +0800
yu kuai <yukuai3@xxxxxxxxxx> escreveu:

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/edac/i5100_edac.c: In function âi5100_read_logâ:
> drivers/edac/i5100_edac.c:489:11: warning: variable âecc_locâ
> set but not used [-Wunused-but-set-variable]
> 
> It is never used, and so can be removed.
> Signed-off-by: yu kuai <yukuai3@xxxxxxxxxx>
> ---
> changes in V2
> -remove the definition of the function i5100_redmemb_ecc_locator()

Sounds ok on my eyes.

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>

>  drivers/edac/i5100_edac.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c
> index 0ddc41e47a96..191aa7c19ded 100644
> --- a/drivers/edac/i5100_edac.c
> +++ b/drivers/edac/i5100_edac.c
> @@ -259,11 +259,6 @@ static inline u32 i5100_nrecmemb_ras(u32 a)
>  	return a & ((1 << 16) - 1);
>  }
>  
> -static inline u32 i5100_redmemb_ecc_locator(u32 a)
> -{
> -	return a & ((1 << 18) - 1);
> -}
> -
>  static inline u32 i5100_recmema_merr(u32 a)
>  {
>  	return i5100_nrecmema_merr(a);
> @@ -486,7 +481,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
>  	u32 dw;
>  	u32 dw2;
>  	unsigned syndrome = 0;
> -	unsigned ecc_loc = 0;
>  	unsigned merr;
>  	unsigned bank;
>  	unsigned rank;
> @@ -499,7 +493,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
>  		pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
>  		syndrome = dw2;
>  		pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
> -		ecc_loc = i5100_redmemb_ecc_locator(dw2);
>  	}
>  
>  	if (i5100_validlog_recmemvalid(dw)) {




Cheers,
Mauro