Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource

[Daniel Lezcano]

On 16/12/2019 12:21, Rafael J. Wysocki wrote:
> On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>
>> ---
>>  drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
>> index d23d8f468c12..511c4f46027a 100644
>> --- a/drivers/cpuidle/cpuidle-kirkwood.c
>> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
>> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
>>  /* Initialize CPU idle by registering the idle states */
>>  static int kirkwood_cpuidle_probe(struct platform_device *pdev)
>>  {
>> -	struct resource *res;
>> -
>> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -	ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
>> +	ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
>>  	if (IS_ERR(ddr_operation_base))
>>  		return PTR_ERR(ddr_operation_base);
>>  
>>
> 
> Daniel, any concerns here?

Acked-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>


-- 
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog