RE: [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation

From: Adam Thomson
Date: Mon Dec 16 2019 - 11:32:57 EST




> -----Original Message-----
> From: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> Sent: 16 December 2019 08:55
> To: Mark Brown <broonie@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx; Support Opensource
> <Support.Opensource@xxxxxxxxxxx>; linux-aspeed@xxxxxxxxxxxxxxxx; linux-
> gpio@xxxxxxxxxxxxxxx; andrew@xxxxxxxx; linus.walleij@xxxxxxxxxx;
> lgirdwood@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> bgolaszewski@xxxxxxxxxxxx; robh+dt@xxxxxxxxxx; joel@xxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; Adam Thomson
> <Adam.Thomson.Opensource@xxxxxxxxxxx>; lee.jones@xxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage
> selection documentation
>
> On 19-12-12 16:51, Mark Brown wrote:
> > On Thu, Dec 12, 2019 at 05:21:53PM +0100, Marco Felsch wrote:
> >
> > > "... what's driving the input ..":
> > > Sorry I didn't get you here. What did you mean? The input is driven by
> > > the host. This can be any gpio line and in my case it is a gpio line
> > > driven by the soc-hw during a suspend operation.
> >
> > Something needs to say what that thing is, especially if it's runtime
> > controllable. In your case from the point of view of software there is
> > actually no enable control so we shouldn't be providing an enable
> > operation to the framework.
>
> The enabel control signal is always available, please check [1] table
> 63. There is a mux in front of the enable pin so:
>
> +-------------
> Seq. |\ | Regulator
> GPI1 | \ |
> GPI2 | | -- > Enable
> GPI3 | / |
> |/ .
> .
> .
>
> Adam please correct me if this is wrong.
>
> [1] https://www.dialog-
> semiconductor.com/sites/default/files/da9062_datasheet_3v6.pdf
>
> Regards,
> Marco
>
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel