Re: [PATCH] net: dsa: b53: Fix egress flooding settings

From: Vivien Didelot
Date: Mon Dec 16 2019 - 11:46:57 EST


On Fri, 13 Dec 2019 12:00:27 -0800, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> There were several issues with 53568438e381 ("net: dsa: b53: Add support for port_egress_floods callback") that resulted in breaking connectivity for standalone ports:
>
> - both user and CPU ports must allow unicast and multicast forwarding by
> default otherwise this just flat out breaks connectivity for
> standalone DSA ports
> - IP multicast is treated similarly as multicast, but has separate
> control registers
> - the UC, MC and IPMC lookup failure register offsets were wrong, and
> instead used bit values that are meaningful for the
> B53_IP_MULTICAST_CTRL register
>
> Fixes: 53568438e381 ("net: dsa: b53: Add support for port_egress_floods callback")
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Reviewed-by: Vivien Didelot <vivien.didelot@xxxxxxxxx>