[PATCH 5.4 119/177] ALSA: fireface: fix return value in error path of isochronous resources reservation

From: Greg Kroah-Hartman
Date: Mon Dec 16 2019 - 13:19:19 EST


From: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>

commit 480136343cbe89426d6c2ab74ffb4e3ee572c7ee upstream.

Even if isochronous resources reservation fails, error code doesn't return
in pcm.hw_params callback.

Cc: <stable@xxxxxxxxxxxxxxx> #5.3+
Fixes: 55162d2bb0e8 ("ALSA: fireface: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks")
Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20191209151655.GA8090@workstation
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
sound/firewire/fireface/ff-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/sound/firewire/fireface/ff-pcm.c
+++ b/sound/firewire/fireface/ff-pcm.c
@@ -219,7 +219,7 @@ static int pcm_hw_params(struct snd_pcm_
mutex_unlock(&ff->mutex);
}

- return 0;
+ return err;
}

static int pcm_hw_free(struct snd_pcm_substream *substream)