Re: [PATCH] sched/fair: fix find_idlest_group() to handle CPU affinity
From: John Stultz
Date: Mon Dec 16 2019 - 20:08:38 EST
On Wed, Dec 4, 2019 at 10:21 AM Vincent Guittot
<vincent.guittot@xxxxxxxxxx> wrote:
>
> Because of CPU affinity, the local group can be skipped which breaks the
> assumption that statistics are always collected for local group. With
> uninitialized local_sgs, the comparison is meaningless and the behavior
> unpredictable. This can even end up to use local pointer which is to
> NULL in this case.
>
> If the local group has been skipped because of CPU affinity, we return
> the idlest group.
>
> Fixes: 57abff067a08 ("sched/fair: Rework find_idlest_group()")
> Reported-by: John Stultz <john.stultz@xxxxxxxxxx>
> Signed-off-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> Tested-by: John Stultz <john.stultz@xxxxxxxxxx>
Just wanted to follow up on this, as its seemed to have missed -rc2?
thanks
-john