Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init

From: Jarkko Sakkinen
Date: Mon Dec 16 2019 - 20:19:56 EST


On Tue, 2019-12-17 at 02:58 +0200, Jarkko Sakkinen wrote:
> On Wed, 2019-12-11 at 16:54 -0700, Jerry Snitselaar wrote:
> > Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when
> > issuing commands to the tpm during initialization, just reserve the
> > chip after wait_startup, and release it when we are ready to call
> > tpm_chip_register.
> >
> > Cc: Christian Bundy <christianbundy@xxxxxxxxxxx>
> > Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> > Cc: Peter Huewe <peterhuewe@xxxxxx>
> > Cc: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> > Cc: Jason Gunthorpe <jgg@xxxxxxxx>
> > Cc: Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > Cc: linux-integrity@xxxxxxxxxxxxxxx
> > Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
> > Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")
> > Signed-off-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>
>
> I pushed to my master with minor tweaks and added my tags.
>
> Please check before I put it to linux-next.

Oops. Forgot to push please check now

git://git.infradead.org/users/jjs/linux-tpmdd.git master

/Jarkko