Re: [PATCH v2 1/2] pwm: fine tune pwm-mtk-disp clock control flow

From: Jitao Shi
Date: Mon Dec 16 2019 - 21:42:02 EST


On Mon, 2019-12-16 at 09:18 +0100, Uwe Kleine-KÃnig wrote:
> Hello,
>
> On Mon, Dec 16, 2019 at 03:01:22PM +0800, Jitao Shi wrote:
> > Match pwm clock when suspend and resume.
> > Prepare and enable disp_pwm clock when disp_pwm enable.
> > Disable and unprepare disp_pwm clock when disp_pwm disable.
>
> Assuming you catched all clock operations (I didn't check), the patch
> looks fine. The commit log could however be improved. Additional to
> describing what the patch does, some words about the motivation would be
> good. Does this fix a bug? Is it to save some power while the PWM isn't
> in use?
>
> Best regards
> Uwe
>

I'll update the commit msg next version.

Thanks for your review.

Best Regards
Jitao