Re: [PATCH] kernel: locking: add releases(lock) annotation

From: Peter Zijlstra
Date: Tue Dec 17 2019 - 04:13:09 EST


On Mon, Dec 16, 2019 at 03:39:52PM +0000, Jules Irenge wrote:
> Add releases(lock) annotation to remove issue detected by sparse tool.
> warning: context imbalance in xxxxxxx() - unexpected unlock
>
> Signed-off-by: Jules Irenge <jbi.octave@xxxxxxxxx>

So, personally I detest these sparse things.

But I'm also confused, as that function already has the annotation, see
spinlock_api_smp.h. In order for sparse to see these annotations at the
usage size, they need to be on the declaration, not the definition.