Re: [PATCH] drivers: char: tpm: remove unneeded MODULE_VERSION() usage

From: Jarkko Sakkinen
Date: Tue Dec 17 2019 - 06:17:13 EST


On Tue, 2019-12-17 at 13:16 +0200, Jarkko Sakkinen wrote:
> On Mon, 2019-12-16 at 09:42 +0100, Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
>
> Take the following line away:
>
> > See also: https://lkml.org/lkml/2017/11/22/480
>
> And just before SOB:
>
> Link: https://lkml.org/lkml/2017/11/22/480
> > Signed-off-by: Enrico Weigelt, metux IT consult <info@xxxxxxxxx>
>
> You have some extra cruft there. It should be:
>
> Signed-off-by: Enrico Weigelt <info@xxxxxxxxx>

Also, the email that you are sending this patch from incorrectly
formatted email address. Please configure your email client to
have just Firstname Lastname as the email.

/Jarkko