Re: [PATCH 03/58] serial_core: Un-ifdef sysrq SUPPORT_SYSRQ

[Greg Kroah-Hartman]

On Fri, Dec 13, 2019 at 12:06:02AM +0000, Dmitry Safonov wrote:
> The SUPPORT_SYSRQ is messy: every .c source should define it before
> including "serial_core.h" if sysrq is supported or struct uart_port will
> differ in sizes. Also this prevents moving to serial_core.c functions:
> uart_handle_sysrq_char(), uart_prepare_sysrq_char(),
> uart_unlock_and_check_sysrq().
> 
> It doesn't save many bytes in the structure, and a better way to reduce
> it's size would be making rs485 and iso7816 pointers.

Yes, the whole thing needs some work with the tool 'pahole' to fix it
up.

thanks,

greg k-h