Re: [PATCH v6 05/15] mfd: bd71828: Support ROHM BD71828 PMIC - core

From: Lee Jones
Date: Tue Dec 17 2019 - 09:25:42 EST


On Tue, 17 Dec 2019, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> On Tue, Dec 17, 2019 at 01:54:30PM +0000, Lee Jones wrote:
> > On Tue, 17 Dec 2019, Vaittinen, Matti wrote:
> > > On Mon, 2019-12-16 at 16:46 +0000, Lee Jones wrote:
> > > > On Wed, 11 Dec 2019, Matti Vaittinen wrote:
> > > >
> > > > > BD71828GW is a single-chip power management IC for battery-powered
> > > > > portable
> > > > > devices. The IC integrates 7 buck converters, 7 LDOs, and a 1500 mA
> > > > > single-cell linear charger. Also included is a Coulomb counter, a
> > > > > real-time
> > > > > clock (RTC), 3 GPO/regulator control pins, HALL input and a 32.768
> > > > > kHz
> > > > > clock gate.
> > > > >
> > > > > Add MFD core driver providing interrupt controller facilities and
> > > > > i2c
> > > > > access to sub device drivers.
> > > > >
> > > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > > > > ---
> > > > >
> > > > > Changes since v5:
> > > > > - No changes
> > > > >
> > > > > drivers/mfd/Kconfig | 15 ++
> > > > > drivers/mfd/Makefile | 2 +-
> > > > > drivers/mfd/rohm-bd71828.c | 319 +++++++++++++++++++++++
> > > > > include/linux/mfd/rohm-bd71828.h | 425
> > > > > +++++++++++++++++++++++++++++++
> > > > > include/linux/mfd/rohm-generic.h | 1 +
> > > > > 5 files changed, 761 insertions(+), 1 deletion(-)
> > > > > create mode 100644 drivers/mfd/rohm-bd71828.c
> > > > > create mode 100644 include/linux/mfd/rohm-bd71828.h

[...]
> >
> > If you have this in your header:
> >
> > GPL-2.0-only
> >
> > Your MODULE tags should read:
> >
> > MODULE_LICENSE("GPL v2");
>
> Nope, as per module.h, which is quoted here, either:
> MODULE_LICENSE("GPL");
> or:
> MODULE_LICENSE("GPL v2");
> mean the exact same thing.

Interesting. I always took a non-specified version to mean:

"... and any other future version of the licence"

Educated, thanks!

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog