Re: [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU

[Chris Down]

Michal Hocko writes:
> On Tue 17-12-19 15:09:21, Chris Down wrote:
> [...]
> > (Side note: I'm moderately baffled that a tightly scoped __maybe_unused is
> > considered sinister but somehow disabling -Wunused-function is on the table
> > :-))
>
> Well, I usually do not like to see __maybe_unused because that is prone
> to bit-rot and loses its usefulness. Looking into the recent git logs
> most -Wunused-function led to the code removal (which is really good
> but the compiler is likely to do that already so the overall impact is
> not that large) or more ifdefery. I do not really see many instance of
> __maybe_unused.

Hmm, but __maybe_unused is easy to find and document the reasons behind nearby, 
and then reevaluate at some later time. On the other hand, it's much *harder* 
to reevaluate which functions actually are unused in the long term if we remove 
-Wunused-function, because enabling it to find candidates will result in an 
incredibly amount of noise from those who have missed unused functions 
previously due to the lack of the warning.

Maybe Qian is right and we should just ignore such patches, but I think that 
comes with its own risks that we will alienate perfectly well intentioned new 
contributors to mm without them having any idea why we did that.