Re: [PATCH] ARM: OMAP: Use ARM SMC Calling Convention when OP-TEE is available

From: Tony Lindgren
Date: Tue Dec 17 2019 - 12:18:48 EST


* Tony Lindgren <tony@xxxxxxxxxxx> [191217 17:11]:
> * Andrew F. Davis <afd@xxxxxx> [191217 17:02]:
> > On 12/17/19 10:07 AM, Tony Lindgren wrote:
> > > * Andrew F. Davis <afd@xxxxxx> [191217 13:14]:
> > >> On 12/16/19 5:41 PM, Tony Lindgren wrote:
> > >>> Please just add omap_early_initcall() to omap-secure.c while at it
> > >>> to deal with this.
> > >>
> > >> omap_early_initcall()s are not called until after all the SMC calls have
> > >> already happened.
> > >
> > > Oh OK. Then let's just add omap_secure_init() that's called from
> > > *_init_early() as late as possible. We will have more use for that
> > > init later on too.
> > >
> >
> >
> > You mean add a call to this omap_secure_init() to every boards init
> > function?
>
> Yes please. We also have some SoCs that need clocks enabled
> and disabled for omap_smc2() so we can then use that to
> intialize the clocks as needed.

And please add the call to omap_secure_init() the SoC specific
*_init_early() functions in:

$ git grep 'void __init ' arch/arm/mach-omap2/io.c | grep early
...

Regards,

Tony