Re: [PATCH v4 1/3] tty: rename tty_kopen() and add new function tty_kopen_shared()

[Uwe Kleine-König]

Hello Jacek,

On Tue, Dec 17, 2019 at 07:08:47PM +0100, Jacek Anaszewski wrote:
> I wanted to test the set but unfortunately this
> patch does not apply. See below for the apparent reason.
>
> > [...]
> > -struct tty_struct *tty_kopen(dev_t device)
> > +static struct tty_struct *tty_kopen(dev_t device, int shared)
> >  {
> >  	struct tty_struct *tty;
> >  	struct tty_driver *driver;
> 
> In mainline, even in v5.5-rc2 we have here NULL assignment:
> 
> struct tty_driver *driver = NULL;

Yeah, if you don't want to wait for Greg's tree to appear in next, this
is the patch you're missing:

	https://lkml.org/lkml/2019/12/17/101

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |