Re: [PATCH] pcie: Add quirk for the Arm Neoverse N1SDP platform

From: Jon Masters
Date: Wed Dec 18 2019 - 00:25:07 EST


On 12/9/19 11:26 AM, Will Deacon wrote:
On Mon, Dec 09, 2019 at 04:06:38PM +0000, Andre Przywara wrote:
From: Deepak Pandey <Deepak.Pandey@xxxxxxx>

The Arm N1SDP SoC suffers from some PCIe integration issues, most
prominently config space accesses to not existing BDFs being answered
with a bus abort, resulting in an SError.

"Do as I say, not as I do"?

In my former role I asked nicely that these patches not be posted upstream, but I see that they ended up being posted anyway. Hacking up upstream Linux to cover for the fact that a (reference) platform is non-standard is not only not good form but it actively harms the community.

You'll have people consume this platform and not realize that it's broken, IP won't get fixed, and generally it'll be a mess. Yes, it's unfortunate, but so was taping out that platform without working PCI. We all know what should have happened, and what the right move ahead is.

Jon.

--
Computer Architect