Re: [PATCH v2] llc2: Remove the condition operator in llc_stat_ev_rx_null_dsap_xid_c and llc_stat_ev_rx_null_dsap_test_c.

From: David Miller
Date: Wed Dec 18 2019 - 01:18:50 EST


From: "Chan Shu Tak, Alex" <alexchan@xxxxxxxxxxx>
Date: Tue, 17 Dec 2019 12:00:36 +0800

> @@ -32,7 +32,7 @@ static int llc_stat_ev_rx_null_dsap_xid_c(struct sk_buff *skb)
> return LLC_PDU_IS_CMD(pdu) && /* command PDU */
> LLC_PDU_TYPE_IS_U(pdu) && /* U type PDU */
> LLC_U_PDU_CMD(pdu) == LLC_1_PDU_CMD_XID &&
> - !pdu->dsap ? 1 : 0; /* NULL DSAP value */
> + !pdu->dsap; /* NULL DSAP value */

This isn't a v2 of your patch, it's a patch against v1 of your patch.

Please do this properly, thank you.