Re: [PATCH] hid: hid-picolcd: fix possible sleep-in-atomic-context bug

From: Jia-Ju Bai
Date: Wed Dec 18 2019 - 07:11:52 EST


Thanks for the reply.

On 2019/12/18 16:41, Bruno PrÃmont wrote:
Hi Jia-Ju,

Your checker has been looking at fallback implementation for
the might-sleep hid_alloc_report_buf(GFP_KERNEL).

Did you have a look at the low-lever bus-driver implementations:
hdev->ll_driver->request
^^^^^^^

Are those all sleeping as well or maybe they don't sleep?\

In fact, I find that a function possibly-related to this function pointer can sleep:

drivers/hid/intel-ish-hid/ishtp-hid.c, 97:
ÂÂÂ kzalloc(GFP_KERNEL) in ishtp_hid_request

But I am not quite sure whether this function is really referenced by the function pointer, so I did not report it.


Best wishes,
Jia-Ju Bai