RE: [PATCH net-next 1/3] net: emaclite: Fix coding style

From: Radhey Shyam Pandey
Date: Wed Dec 18 2019 - 08:34:57 EST


> -----Original Message-----
> From: David Miller <davem@xxxxxxxxxxxxx>
> Sent: Wednesday, December 18, 2019 3:27 AM
> To: Radhey Shyam Pandey <radheys@xxxxxxxxxx>
> Cc: Michal Simek <michals@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; git
> <git@xxxxxxxxxx>
> Subject: Re: [PATCH net-next 1/3] net: emaclite: Fix coding style
>
> From: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>
> Date: Mon, 16 Dec 2019 17:38:08 +0530
>
> > - spinlock_t reset_lock;
> > + spinlock_t reset_lock; /* lock used for synchronization */
>
> If you're just going to put the comment there to shut up the warnings,
> I'm not applying your patches.
>
> You have to write a thoughtful comment which explains what this lock
> actually protects.
Thanks for the review. Sure, will fix reset_lock comment
and also its kernel-doc description in v2.