Re: [PATCH 13/13] mmc: au1xmmc: switch to platform_get_irq

[Ulf Hansson]

- trimmed cc list (please do that also for any future submissions).

On Sun, 15 Dec 2019 at 18:51, Yangtao Li <tiny.windzz@xxxxxxxxx> wrote:
>
> platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
> requesting IRQ's resources, as they can be not ready yet. Using
> platform_get_irq() instead is preferred for getting IRQ even if it
> was not retrieved earlier.
>
> Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx>

Patch 1->13 applied for next, thanks!

Next time, please use a cover-letter when you send a series.

Kind regards
Uffe


> ---
>  drivers/mmc/host/au1xmmc.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c
> index bc8aeb47a7b4..8823680ca42c 100644
> --- a/drivers/mmc/host/au1xmmc.c
> +++ b/drivers/mmc/host/au1xmmc.c
> @@ -984,12 +984,9 @@ static int au1xmmc_probe(struct platform_device *pdev)
>                 goto out2;
>         }
>
> -       r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -       if (!r) {
> -               dev_err(&pdev->dev, "no IRQ defined\n");
> +       host->irq = platform_get_irq(pdev, 0);
> +       if (host->irq < 0)
>                 goto out3;
> -       }
> -       host->irq = r->start;
>
>         mmc->ops = &au1xmmc_ops;
>
> --
> 2.17.1
>