Re: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface
From: Sudeep Holla
Date: Wed Dec 18 2019 - 09:46:06 EST
On Wed, Dec 04, 2019 at 03:29:14PM -0800, Jolly Shah wrote:
> This patch series adds xilinx specific sysfs interface for below
> purposes:
> - Register access
> - Set shutdown scope
> - Set boot health status bit
This series defeats the whole abstraction EEMI provides. By providing
direct register accesses, you are allowing user-space to do whatever it
wants. I had NACKed this idea before. Has anything changed ?
If you need it for testing firmware, better put them in debugfs which is
off on production builds.
--
Regards,
Sudeep