Re: [PATCH v2 0/9] thunderbolt: Add support for USB4

From: Mika Westerberg
Date: Wed Dec 18 2019 - 10:30:11 EST


On Wed, Dec 18, 2019 at 03:43:16PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 17, 2019 at 03:33:36PM +0300, Mika Westerberg wrote:
> > Hi all,
> >
> > USB4 is the public specification of Thunderbolt 3 protocol and can be
> > downloaded here:
> >
> > https://www.usb.org/sites/default/files/USB4%20Specification_1.zip
> >
> > USB4 is about tunneling different protocols over a single cable (in the
> > same way as Thunderbolt). The current USB4 spec supports PCIe, Display Port
> > and USB 3.x, and also software based protocols such as networking between
> > domains (hosts).
> >
> > So far PCs have been using firmware based Connection Manager (FW CM, ICM)
> > and Apple systems have been using software based one (SW CM, ECM). A
> > Connection Manager is the entity that handles creation of different tunnel
> > types through the USB4 (and Thunderbolt) fabric. With USB4 the plan is to
> > have software based Connection Manager everywhere but some early systems
> > will come with firmware based connection manager.
> >
> > Current Linux Thunderbolt driver supports both "modes" and can detect which
> > one to use dynamically.
> >
> > This series extends the Linux Thunderbolt driver to support USB4 compliant
> > hosts and devices (this applies to both firmware and software based
> > connection managers). USB4 Features enabled by this series include:
> >
> > - PCIe tunneling
> > - Display Port tunneling
> > - USB 3.x tunneling
> > - P2P networking (implemented in drivers/net/thunderbolt.c)
> > - Host and device NVM firmware upgrade
> >
> > Power management support is still work in progress. It will be submitted
> > later on once properly tested.
> >
> > The previous versions of the series can be seen here:
> >
> > v1: https://lore.kernel.org/linux-usb/20191023112154.64235-1-mika.westerberg@xxxxxxxxxxxxxxx/
> > RFC: https://lore.kernel.org/lkml/20191001113830.13028-1-mika.westerberg@xxxxxxxxxxxxxxx/
> >
> > Changes from v1:
> >
> > * Rebased on top of v5.5-rc2.
> > * Add a new patch to populate PG field in hotplug ack packet.
> > * Rename the networking driver Kconfig symbol to CONFIG_USB4_NET to
> > follow the driver itself (CONFIG_USB4).
>
> At a quick glance, this looks nice and sane, good job. I've taken all
> of these into my tree, let's see if 0-day has any problems with it :)

Thanks :)