RE: [PATCH v3] platform/mellanox: fix the mlx-bootctl sysfs

[Liming Sun]

Sorry I misunderstood the last comment. Verified and posted v4.

- Liming

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Sent: Wednesday, December 18, 2019 1:00 PM
> To: Liming Sun <lsun@xxxxxxxxxxxx>
> Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>; Darren Hart <dvhart@xxxxxxxxxxxxx>; Vadim Pasternak <vadimp@xxxxxxxxxxxx>; David
> Woods <dwoods@xxxxxxxxxxxx>; Platform Driver <platform-driver-x86@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v3] platform/mellanox: fix the mlx-bootctl sysfs
> 
> On Wed, Dec 18, 2019 at 5:25 PM Liming Sun <lsun@xxxxxxxxxxxx> wrote:
> >
> > This is a follow-up commit for the sysfs attributes to change
> > from DRIVER_ATTR to DEVICE_ATTR according to some initial comments.
> > In such case, it's better to point the sysfs path to the device
> > itself instead of the driver. The ABI document is also updated.
> >
> > Fixes: 79e29cb8fbc5 ("platform/mellanox: Add bootctl driver for Mellanox BlueField Soc")
> > Signed-off-by: Liming Sun <lsun@xxxxxxxxxxxx>
> 
> ...
> 
> > -ATTRIBUTE_GROUPS(mlxbf_bootctl);
> 
> What's wrong with above macro?
> 
> > +static const struct attribute_group mlxbf_bootctl_group = {
> > +       .attrs  = mlxbf_bootctl_attrs,
> > +};
> 
> ...
> 
> > +static const struct attribute_group *mlxbf_bootctl_dev_groups[] = {
> > +       &mlxbf_bootctl_group,
> > +       NULL
> > +};
> 
> --
> With Best Regards,
> Andy Shevchenko