Re: [PATCH 1/2] rxrpc: Unlock new call in rxrpc_new_incoming_call() rather than the caller

From: Peter Zijlstra
Date: Wed Dec 18 2019 - 14:10:15 EST


On Wed, Dec 18, 2019 at 05:54:50PM +0000, David Howells wrote:
> Move the unlock and the ping transmission for a new incoming call into
> rxrpc_new_incoming_call() rather than doing it in the caller. This makes
> it clearer to see what's going on.
>
> Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> cc: Ingo Molnar <mingo@xxxxxxxxxx>
> cc: Will Deacon <will@xxxxxxxxxx>
> cc: Davidlohr Bueso <dave@xxxxxxxxxxxx>

Thanks, that looks much nicer!

Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>