Re: [PATCH 0/2] pipe: Fixes [ver #2]

From: Josh Triplett
Date: Wed Dec 18 2019 - 15:59:10 EST


On Mon, Dec 09, 2019 at 10:18:57AM -0800, Linus Torvalds wrote:
> On Mon, Dec 9, 2019 at 9:57 AM Akemi Yagi <toracat@xxxxxxxxxx> wrote:
> >
> > In addition to the Fedora make-4.2.1-4.fc27 (1) mentioned by Linus,
> > RHEL 8 make-4.2.1-9.el8 (2) is affected. The patch applied to Fedora
> > make (3) has been confirmed to fix the issue in RHEL's make.
> >
> > Those are the only real-world examples I know of. I have no idea how
> > widespread this thing is...
>
> Looks like opensuse and ubuntu are also on 4.2.1 according to
>
> https://software.opensuse.org/package/make
> https://packages.ubuntu.com/cosmic/make
>
> so apparently the bug is almost universal with the big three sharing
> this buggy version.

Debian and Ubuntu have make 4.2.1-1.2, which includes "[SV 51159] Use a
non-blocking read with pselect to avoid hangs." and various other fixes.
https://metadata.ftp-master.debian.org/changelogs/main/m/make-dfsg/make-dfsg_4.2.1-1.2_changelog
So, both Debian and Ubuntu should be fine with the pipe improvements.
(I'm testing that now.)

Is the version of your non-thundering-herd pipe wakeup patch attached to
https://lore.kernel.org/lkml/CAHk-=wicgTacrHUJmSBbW9MYAdMPdrXzULPNqQ3G7+HkLeNf1Q@xxxxxxxxxxxxxx/
still the best version to test performance with?