Re: [PATCH] KEYS: trusted: fix type warnings in ntohl/nthos
From: Jarkko Sakkinen
Date: Wed Dec 18 2019 - 17:06:24 EST
On Tue, 2019-12-17 at 11:09 +0000, Ben Dooks (Codethink) wrote:
> The ntohl takes a __be32 and ntohs takes __be16, so cast to
> those types before passing it to the byte swapping functions.
>
> Note, would be32_to_cpu and be16_to_cpu be better here?
Yes, can you refine this?
Also in commit message you could
"
E.g.
security/keys/trusted-keys/trusted_tpm1.c:201:19: warning: cast to restricted __be32
"
We get the idea from one line :-)
/Jarkko