Re: [PATCH v2 1/3] dt-bindings: misc: Add dt bindings for traffic generator

[Rob Herring]

On Mon, Dec 09, 2019 at 11:41:26AM +0530, shubhrajyoti.datta@xxxxxxxxx wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> 
> Add dt bindings for xilinx traffic generator IP.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> ---
>  .../bindings/misc/xlnx,axi-traffic-gen.txt         | 25 ++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/xlnx,axi-traffic-gen.txt

Please convert to a DT schema.

> 
> diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-traffic-gen.txt b/Documentation/devicetree/bindings/misc/xlnx,axi-traffic-gen.txt
> new file mode 100644
> index 0000000..6edb8f6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/xlnx,axi-traffic-gen.txt
> @@ -0,0 +1,25 @@
> +* Xilinx AXI Traffic generator IP
> +
> +Required properties:
> +- compatible: "xlnx,axi-traffic-gen"
> +- interrupts: Should contain AXI Traffic Generator interrupts.

How many and what are they.

> +- interrupt-parent: Must be core interrupt controller.

Drop this. It could be in a parent node.

> +- reg: Should contain AXI Traffic Generator registers location and length.
> +- interrupt-names: Should contain both the intr names of device - error
> +		   and completion.

Needs exact strings.

> +- xlnx,device-id: Device instance Id.
> +
> +Optional properties:
> +- clocks: Input clock specifier. Refer to common clock bindings.
> +
> +Example:
> +++++++++
> +axi_traffic_gen_1: axi-traffic-gen@76000000 {
> +	compatible = "xlnx,axi-traffic-gen-1.0", "xlnx,axi-traffic-gen";

Doesn't match the above. I'd drop the 2nd string.

> +	clocks = <&clkc 15>;
> +	interrupts = <0 2 2 2>;
> +	interrupt-parent = <&axi_intc_1>;
> +	interrupt-names = "err-out", "irq-out";
> +	reg = <0x76000000 0x800000>;
> +	xlnx,device-id = <0x0>;
> +} ;
> -- 
> 2.1.1
>