Re: [PATCH v3 02/10] drm/bridge: dw-hdmi: add max bpc connector property

[Neil Armstrong]

On 18/12/2019 16:49, Laurent Pinchart wrote:
> Hi Neil and Jonas,
> 
> Thank you for the patch.
> 
> On Wed, Dec 18, 2019 at 04:46:29PM +0100, Neil Armstrong wrote:
>> From: Jonas Karlman <jonas@xxxxxxxxx>
>>
>> Add the max_bpc property to the dw-hdmi connector to prepare support
>> for 10, 12 & 16bit output support.
>>
>> Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx>
>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
>> ---
>>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> index 6a0b4b3a6739..e7a0600f8cc5 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> @@ -2368,6 +2368,10 @@ static int dw_hdmi_bridge_attach(struct drm_bridge *bridge)
>>  				    DRM_MODE_CONNECTOR_HDMIA,
>>  				    hdmi->ddc);
>>  
>> +	drm_atomic_helper_connector_reset(connector);
>> +
>> +	drm_connector_attach_max_bpc_property(connector, 8, 16);
>> +
> 
> I'm not asking you to rework this, but have you given any thought on how
> we would be able to support this feature in a model where the bridge
> wouldn't create a connector anymore (as done in the latest version of
> the omapdrm series) ?

Not yet, but the plan is to have this serie merged (it's on the list for more than 1y now),
then we'll switch to a separate connector.

> 
>>  	if (hdmi->version >= 0x200a && hdmi->plat_data->use_drm_infoframe)
>>  		drm_object_attach_property(&connector->base,
>>  			connector->dev->mode_config.hdr_output_metadata_property, 0);
> 

Neil