Re: [PATCH v2 2/4] nvmem: add support for the write-protect pin

From: Srinivas Kandagatla
Date: Thu Dec 19 2019 - 05:58:23 EST




On 10/12/2019 15:41, Khouloud Touil wrote:
The write-protect pin handling looks like a standard property that
could benefit other users if available in the core nvmem framework.

Instead of modifying all the memory drivers to check this pin, make
the NVMEM subsystem check if the write-protect GPIO being passed
through the nvmem_config or defined in the device tree and pull it
low whenever writing to the memory.

There was a suggestion for introducing the gpiodesc from pdata, but
as pdata is already removed it could be replaced by adding it to
nvmem_config.

Reference: https://lists.96boards.org/pipermail/dev/2018-August/001056.html

Signed-off-by: Khouloud Touil <ktouil@xxxxxxxxxxxx>
---
drivers/nvmem/core.c | 19 +++++++++++++++++--
drivers/nvmem/nvmem.h | 2 ++
include/linux/nvmem-provider.h | 3 +++
3 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>