Re: [PATCH v2 2/3] misc: xilinx_flex: Add support for the flex noc Performance Monitor

[Greg KH]

On Fri, Dec 06, 2019 at 11:09:57AM +0530, shubhrajyoti.datta@xxxxxxxxx wrote:
> +/**
> + * xflex_remove - Driver remove function
> + * @pdev: Pointer to the platform_device structure
> + *
> + * This function frees all the resources allocated to the device.
> + *
> + * Return: 0 always
> + */

No need for kerneldoc documentation for static functions.

> +static int xflex_remove(struct platform_device *pdev)
> +{
> +	sysfs_remove_groups(&pdev->dev.kobj, xflex_groups);

Your attribute groups can, and should, be automatically created by the
driver core.  Set the driver's dev_groups pointer and that will happen
for you.

thanks,

greg k-h