Re: [PATCH AUTOSEL 5.4 105/350] iio: chemical: atlas-ph-sensor: fix iio_triggered_buffer_predisable() position

From: Sasha Levin
Date: Thu Dec 19 2019 - 12:34:43 EST


On Sun, Dec 15, 2019 at 03:25:27PM -0800, Matt Ranostay wrote:
On Sun, Dec 15, 2019 at 7:53 AM Jonathan Cameron
<jic23@xxxxxxxxxxxxxxxxxxxxx> wrote:

On Tue, 10 Dec 2019 16:03:30 -0500
Sasha Levin <sashal@xxxxxxxxxx> wrote:

> From: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
>
> [ Upstream commit 0c8a6e72f3c04bfe92a64e5e0791bfe006aabe08 ]
>
> The iio_triggered_buffer_{predisable,postenable} functions attach/detach
> the poll functions.
>
> The iio_triggered_buffer_predisable() should be called last, to detach the
> poll func after the devices has been suspended.
>
> The position of iio_triggered_buffer_postenable() is correct.
>
> Note this is not stable material. It's a fix in the logical
> model rather fixing an actual bug. These are being tidied up
> throughout the subsystem to allow more substantial rework that
> was blocked by variations in how things were done.

See comment. This is not what I would consider stable material.


Outside of the comment, which really isn't probably enough to avoid
the autoselection script from detecting it (could be "stable" in the
message alone selects it :) ),
is there any way to signal that a patch is "NOT for stable trees"?
Probably don't want to clutter up the commit messages of course.

That commit message should have been enough, I'll add some more
filtering to catch instances like that.

--
Thanks,
Sasha