Re: [PATCH v1 3/4] scsi: ufs-mediatek: configure customized auto-hibern8 timer

From: Alim Akhtar
Date: Thu Dec 19 2019 - 13:26:21 EST


On Fri, Dec 13, 2019 at 3:04 PM Stanley Chu <stanley.chu@xxxxxxxxxxxx> wrote:
>
> Configure customized auto-hibern8 timer in MediaTek Chipsets.
>
> Signed-off-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index 690483c78212..71e2e0e4ea11 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -7,6 +7,7 @@
> */
>
> #include <linux/arm-smccc.h>
> +#include <linux/bitfield.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/phy/phy.h>
> @@ -300,6 +301,13 @@ static int ufs_mtk_post_link(struct ufs_hba *hba)
> /* enable unipro clock gating feature */
> ufs_mtk_cfg_unipro_cg(hba, true);
>
> + /* configure auto-hibern8 timer to 10ms */
> + if (ufshcd_is_auto_hibern8_supported(hba)) {
> + ufshcd_auto_hibern8_update(hba,
> + FIELD_PREP(UFSHCI_AHIBERN8_TIMER_MASK, 10) |
> + FIELD_PREP(UFSHCI_AHIBERN8_SCALE_MASK, 3));
> + }
> +
> return 0;
> }
>
> --
> 2.18.0



--
Regards,
Alim