Re: [RESEND PATCH v1 14/15] dt-bindings: phy: phy-cadence-torrent: Add platform dependent compatible string

From: Rob Herring
Date: Thu Dec 19 2019 - 16:25:53 EST


On Wed, Dec 11, 2019 at 02:09:19PM +0100, Yuti Amonkar wrote:
> Add a new compatible string used for TI SoCs using Torrent PHY.
>
> Signed-off-by: Yuti Amonkar <yamonkar@xxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> index 8069498..60e024b 100644
> --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> @@ -15,7 +15,9 @@ maintainers:
>
> properties:
> compatible:
> - const: cdns,torrent-phy
> + anyOf:

Should be an enum or if both strings can be present then you need 2
oneOf entries for 1 string and 2 strings.

> + - const: cdns,torrent-phy
> + - const: ti,j721e-serdes-10g
>
> clocks:
> maxItems: 1
> --
> 2.7.4
>