Re: [PATCH v7 3/3] iio: (bma400) basic regulator support

From: Linus Walleij
Date: Thu Dec 19 2019 - 16:41:33 EST


On Thu, Dec 19, 2019 at 12:06 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Dec 19, 2019 at 6:28 AM Dan Robertson <dan@xxxxxxxxxxxxxxx> wrote:
> >
> > Add support for the VDD and VDDIO regulators using the regulator
> > framework.
> ...
>
> > + data->vdd_supply = devm_regulator_get(data->dev, "vdd");
>
> > + data->vddio_supply = devm_regulator_get(data->dev, "vddio");
>
> devm_regulator_bulk_get() ?

I always thought to use regulator_bulk* maybe 3 regulators and
definitely for more that 4 as it also clouds the view bit and is not
as straightforward to read as the single functions, but I suppose
it is a bit subjective :)

Linus Walleij