Re: [PATCH v5 6/8] media: v4l2-core: fix v4l2_buffer handling for time64 ABI

From: Zach van Rijn
Date: Thu Dec 19 2019 - 18:41:43 EST


On Sat, 2019-12-14 at 22:44 +0100, Arnd Bergmann wrote:
> On Sat, Dec 14, 2019 at 12:27 PM Hans Verkuil <hverkuil@xs4all
> .nl> wrote:
> >
> > On 12/13/19 4:32 PM, Hans Verkuil wrote:
> > > > > ...
> > > >
> > > > I've heard good things about the prebuilt toolchains
> > > > from http://musl.cc/.
> > > > These seems to come with a libstdc++, but I have not
> > > > tried that myself.
> > >
> > > I'll see if I can give those a spin, but if I can't get it
> > > to work quickly,
> > > then I don't plan on spending much time on it.
> >
> > I managed to build v4l2-ctl/compliance with those
> > toolchains, but they seem to be
> > still using a 32-bit time_t.
> >
> > Do I need to get a specific version or do something special?
>
> My mistake: only musl-1.2.0 and up have 64-bit time_t, but
> this isn't released yet. According to https://wiki.musl-
> libc.org/roadmap.html, the release was planned for last month,
> no idea how long it will take.
>
> It appears that a snapshot build at
> http://more.musl.cc/7.5.0/x86_64-linux-musl/i686-linux-musl-
> native.tgz is new enough to have 64-bit time_t (according to
> include/bits/alltypes.h), but this is a month old as well, so
> it may have known bugs.
>
> Adding Zach to Cc here, maybe he already has plans for another
> build with the latest version.

Yes, that's correct. The current (as of 2019-12-19) GCC 9.2.1
offering is based on musl 1.1.24, though the 7.5.0 release is
using a more recent git tag only due to timing/availability.

Within reason, I'm happy to bump versions with justification.
Rebuilding takes about a full day but no time on my end.

Rich sent out a message [1] just today suggesting there is still
some time64 work to be done, so once he pushes those patches
I'll build and release new toolchains for 9.2, 8.3, and 7.5.


ZV

[1]: https://www.openwall.com/lists/musl/2019/12/19/6