Re: [PATCH] net/mlx5e: Fix printk format warning

From: Joe Perches
Date: Thu Dec 19 2019 - 21:07:44 EST


On Thu, 2019-12-19 at 16:15 -0800, Olof Johansson wrote:
> Use "%zu" for size_t. Seen on ARM allmodconfig:
[]
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.c b/drivers/net/ethernet/mellanox/mlx5/core/wq.c
[]
> @@ -89,7 +89,7 @@ void mlx5_wq_cyc_wqe_dump(struct mlx5_wq_cyc *wq, u16 ix, u8 nstrides)
> len = nstrides << wq->fbc.log_stride;
> wqe = mlx5_wq_cyc_get_wqe(wq, ix);
>
> - pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %ld\n",
> + pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %zu\n",
> mlx5_wq_cyc_get_size(wq), wq->cur_sz, ix, len);
> print_hex_dump(KERN_WARNING, "", DUMP_PREFIX_OFFSET, 16, 1, wqe, len, false);
> }

One might expect these 2 outputs to be at the same KERN_<LEVEL> too.
One is KERN_INFO the other KERN_WARNING