Re: [PATCH] crypto: hisilicon - still no need to check return value of debugfs_create functions

From: Herbert Xu
Date: Fri Dec 20 2019 - 02:05:21 EST


On Mon, Dec 09, 2019 at 04:21:51PM +0100, Greg Kroah-Hartman wrote:
> Just like in 4a97bfc79619 ("crypto: hisilicon - no need to check return
> value of debugfs_create functions"), there still is no need to ever
> check the return value. The function can work or not, but the code
> logic should never do something different based on this.
>
> Cc: Zhou Wang <wangzhou1@xxxxxxxxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: linux-crypto@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/crypto/hisilicon/hpre/hpre_main.c | 28 +++++------------------
> 1 file changed, 6 insertions(+), 22 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt