Re: [PATCH v2 44/45] KVM: Move putting of vcpu->pid to kvm_vcpu_destroy()

From: Cornelia Huck
Date: Fri Dec 20 2019 - 05:16:40 EST


On Wed, 18 Dec 2019 13:55:29 -0800
Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote:

> Move the putting of vcpu->pid to kvm_vcpu_destroy(). vcpu->pid is
> guaranteed to be NULL when kvm_vcpu_uninit() is called in the error path
> of kvm_vm_ioctl_create_vcpu(), e.g. it is explicitly nullified by
> kvm_vcpu_init() and is only changed by KVM_RUN.
>
> No functional change intended.
>
> Acked-by: Christoffer Dall <christoffer.dall@xxxxxxx>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> ---
> virt/kvm/kvm_main.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>