Re: [PATCH] riscv: export flush_icache_all to modules

From: Paul Walmsley
Date: Fri Dec 20 2019 - 06:05:09 EST


On Mon, 16 Dec 2019, Olof Johansson wrote:

> This is needed by LKDTM (crash dump test module), it calls
> flush_icache_range(), which on RISC-V turns into flush_icache_all(). On
> other architectures, the actual implementation is exported, so follow
> that precedence and export it here too.
>
> Fixes build of CONFIG_LKDTM that fails with:
> ERROR: "flush_icache_all" [drivers/misc/lkdtm/lkdtm.ko] undefined!

In the past we've resisted doing this; see

https://lore.kernel.org/linux-riscv/20190611134945.GA28532@xxxxxx/

under the principle that we don't want modules to be able to flush the I$
directly via this interface. But maybe, like moving the L2 related code
out of arch/riscv, we should just do it.


- Paul